Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the codebase overview schematic to docs #1231

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Add the codebase overview schematic to docs #1231

merged 7 commits into from
Nov 15, 2021

Conversation

watiss
Copy link
Contributor

@watiss watiss commented Oct 17, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2021 •
edited
Loading

Codecov Report

Merging #1231 (da361d8) into master (232aeb2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1231   +/-   ##
=======================================
  Coverage   90.69%   90.69%           
=======================================
  Files          96       96           
  Lines        7761     7761           
=======================================
  Hits         7039     7039           
  Misses        722      722

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 232aeb2...da361d8. Read the comment docs.

adamgayoso
adamgayoso requested changes Oct 18, 2021
View reviewed changes
Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better off somewhere on the docs site, and we can link to it from the "rapid development" part of the readme

@adamgayoso
Copy link
Member

I'd like to get this in for the next patch. I think in the background section here as a new page is good?

https://docs.scvi-tools.org/en/stable/user_guide/index.html

@adamgayoso adamgayoso changed the title Add the codebase overview schematic to README Add the codebase overview schematic to docs Nov 15, 2021
@adamgayoso adamgayoso enabled auto-merge (squash) November 15, 2021 21:38
@adamgayoso adamgayoso merged commit aa5a6f2 into master Nov 15, 2021
@adamgayoso adamgayoso deleted the valehvpa/add_figure_to_site branch November 15, 2021 21:38
@adamgayoso
Copy link
Member

@meeseeksdev backport to 0.14.x

meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Nov 15, 2021
@watiss @meeseeksmachine
Backport PR scverse#1231: Add the codebase overview schematic to docs
12ab994
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 15, 2021
Merged
adamgayoso pushed a commit that referenced this pull request Nov 16, 2021
@meeseeksmachine @watiss
Backport PR #1231: Add the codebase overview schematic to docs (#1261)
1232a73 
Co-authored-by: Valeh Valiollah Pour Amiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgayoso adamgayoso adamgayoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@watiss @adamgayoso