Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LDA tutorial image #1213

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Update LDA tutorial image #1213

merged 2 commits into from
Oct 8, 2021

Conversation

justjhong
Copy link
Contributor

@justjhong justjhong commented Oct 8, 2021

Updates LDA image to show wordcloud after removing mitochondrial genes. Updates LDA tutorial from submodule as well.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1213 (ea0b9e6) into master (233cf2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   90.62%   90.62%           
=======================================
  Files          95       95           
  Lines        7701     7701           
=======================================
  Hits         6979     6979           
  Misses        722      722           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 233cf2c...ea0b9e6. Read the comment docs.

@adamgayoso
Copy link
Member

This is good, but we should establish the backporting strategy with @watiss

@watiss
Copy link
Contributor

watiss commented Oct 8, 2021

This is good, but we should establish the backporting strategy with @watiss

Why don't you guys follow the guide I wrote up here so that we can test how helpful it actually is :)

@justjhong
Copy link
Contributor Author

Added a label for auto backporting can @watiss or @adamgayoso approve?

@justjhong justjhong requested a review from watiss October 8, 2021 20:13
@justjhong justjhong merged commit 60957c6 into master Oct 8, 2021
@justjhong justjhong deleted the jhong/fixldapng branch October 8, 2021 20:14
@justjhong
Copy link
Contributor Author

@meeseeksdev backport to 0.14.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants