Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stereoscope User Guide #1180

Merged
merged 8 commits into from
Sep 29, 2021
Merged

Stereoscope User Guide #1180

merged 8 commits into from
Sep 29, 2021

Conversation

justjhong
Copy link
Contributor

Fixes #1174

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1180 (fd6e07d) into master (e0b2faf) will increase coverage by 0.04%.
The diff coverage is 97.82%.

❗ Current head fd6e07d differs from pull request most recent head 7d67e49. Consider uploading reports for the commit 7d67e49 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
+ Coverage   90.68%   90.72%   +0.04%     
==========================================
  Files          95       95              
  Lines        7621     7667      +46     
==========================================
+ Hits         6911     6956      +45     
- Misses        710      711       +1     
Impacted Files Coverage Δ
scvi/data/__init__.py 100.00% <ø> (ø)
scvi/data/_built_in_data/_cite_seq.py 98.95% <97.72%> (-1.05%) ⬇️
scvi/data/_datasets.py 96.07% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d3651...7d67e49. Read the comment docs.

@adamgayoso
Copy link
Member

Can you move the stereoscope file to the models directory?

@adamgayoso adamgayoso added this to the 0.14.0 milestone Sep 28, 2021
docs/user_guide/models/stereoscope.rst Outdated Show resolved Hide resolved
docs/user_guide/models/stereoscope.rst Outdated Show resolved Hide resolved
Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamgayoso adamgayoso merged commit 9cabc33 into master Sep 29, 2021
@adamgayoso adamgayoso deleted the jhong/stereoscopeguide branch September 29, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User guide: Stereoscope
2 participants