Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytorch lightning's seed everything to set seed #1151

Merged
merged 4 commits into from
Sep 28, 2021
Merged

Conversation

mjayasur
Copy link
Contributor

@mjayasur mjayasur commented Sep 9, 2021

Fix #1111

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1151 (786684e) into master (9855238) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1151      +/-   ##
==========================================
- Coverage   90.68%   90.68%   -0.01%     
==========================================
  Files          95       95              
  Lines        7622     7621       -1     
==========================================
- Hits         6912     6911       -1     
  Misses        710      710              
Impacted Files Coverage Δ
scvi/_settings.py 87.77% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9855238...786684e. Read the comment docs.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to properly test this right?

  1. Set the seed and train a model 1 epoch
  2. Set the seed again and do the same
  3. NN weights should be exactly the same

@adamgayoso adamgayoso added this to the 0.14.0 milestone Sep 27, 2021
@adamgayoso adamgayoso merged commit 12402cd into master Sep 28, 2021
@adamgayoso adamgayoso deleted the michael/seed branch September 28, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pytorch lightning's seed everything in our config to set seed
3 participants