Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scANVI max_epochs bug when pretrained #1079

Merged
merged 3 commits into from
May 31, 2021
Merged

Conversation

galenxing
Copy link
Contributor

We have a heuristic for max_epochs if scanvi was pretrained, but the heuristic would overwrite max_epochs the user provided.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.67%. Comparing base (49ae51f) to head (9dffd10).

Files Patch % Lines
scvi/model/_scanvi.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
- Coverage   90.70%   90.67%   -0.03%     
==========================================
  Files          90       90              
  Lines        6745     6745              
==========================================
- Hits         6118     6116       -2     
- Misses        627      629       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galenxing galenxing requested a review from adamgayoso May 31, 2021 20:35
@galenxing galenxing merged commit 8c3ca35 into master May 31, 2021
@galenxing galenxing deleted the scanvi_pretraining branch May 31, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants