-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding mixin classes for pyro training and posterior sampling #1059
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 90.67% 90.64% -0.03%
==========================================
Files 90 91 +1
Lines 6745 6885 +140
==========================================
+ Hits 6116 6241 +125
- Misses 629 644 +15 ☔ View full report in Codecov by Sentry. |
Interestingly, the last test works but cell2location with full data and non-amortised inference gives an error which I do not quite understand. See HTML attached (can be reproduced by taking this notebook to colab). UPD: Problem solved (a48d8ff). |
Co-authored-by: Adam Gayoso <[email protected]>
Co-authored-by: Adam Gayoso <[email protected]>
Co-authored-by: Adam Gayoso <[email protected]>
Co-authored-by: Adam Gayoso <[email protected]>
Co-authored-by: Adam Gayoso <[email protected]>
Sorry for the accidental merge again, I don't get why this merge happened. I am trying to merge pyro-mixin into pyro-cell2location branch using GitHub pull request web interface. For some reason, that seems to create a merge commit from pyro-cell2location into pyro-mixin. UPD: fixed now |
@adamgayoso after talking to @martinjankowiak I think the default optimiser should be Adam, not ClippedAdam. I can change that. Should I modify this branch/PR or create a new one? |
This PR adds mixin classes for
It also fixes an issue where pyro model history was erased on load
Fixes #1031