-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De delta eps #1043
De delta eps #1043
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1043 +/- ##
==========================================
+ Coverage 90.70% 90.71% +0.01%
==========================================
Files 90 90
Lines 6615 6658 +43
==========================================
+ Hits 6000 6040 +40
- Misses 615 618 +3 ☔ View full report in Codecov by Sentry. |
scvi/utils/_differential.py
Outdated
|
||
if where_zero_a.sum() >= 1: | ||
artefact_scales_a = max_scales_a[where_zero_a] | ||
eps_a = np.percentile(artefact_scales_a, q=90) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe should make this percentile an argument with default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this should be a parameter in get_bayes_factors
? I replaced this default value in estimate_pseudocounts_offset
but not in get_bayes_factors yet
I renamed |
Fixes #1042