Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De string queries #1041

Merged
merged 16 commits into from
Apr 27, 2021
Merged

De string queries #1041

merged 16 commits into from
Apr 27, 2021

Conversation

PierreBoyeau
Copy link
Contributor

Fixes #1040

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.70%. Comparing base (19b9c4f) to head (26c04ee).

Files Patch % Lines
scvi/model/base/_utils.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1041      +/-   ##
==========================================
- Coverage   90.70%   90.70%   -0.01%     
==========================================
  Files          90       90              
  Lines        6607     6615       +8     
==========================================
+ Hits         5993     6000       +7     
- Misses        614      615       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamgayoso adamgayoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the docstring in rnamixin, totalvi de function and I think peakvi.

scvi/model/base/_utils.py Outdated Show resolved Hide resolved
scvi/_docs.py Outdated Show resolved Hide resolved
scvi/_docs.py Outdated Show resolved Hide resolved
scvi/model/base/_utils.py Outdated Show resolved Hide resolved
scvi/model/base/_utils.py Outdated Show resolved Hide resolved
scvi/model/base/_utils.py Show resolved Hide resolved
scvi/model/base/_utils.py Outdated Show resolved Hide resolved
tests/core/test_differential.py Outdated Show resolved Hide resolved
tests/core/test_differential.py Outdated Show resolved Hide resolved
@adamgayoso adamgayoso merged commit 75eeb81 into master Apr 27, 2021
@adamgayoso adamgayoso deleted the DE_string_queries branch April 27, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow string queries for differential expression
2 participants