Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes numpy.array() on tensors to .numpy() #1016

Merged
merged 1 commit into from
Apr 6, 2021
Merged

changes numpy.array() on tensors to .numpy() #1016

merged 1 commit into from
Apr 6, 2021

Conversation

mjayasur
Copy link
Contributor

@mjayasur mjayasur commented Apr 5, 2021

close #1015

@codecov
Copy link

codecov bot commented Apr 5, 2021 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (3e4d2ff) to head (966dcc4).

Files Patch % Lines
scvi/model/_totalvi.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1016   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files          86       86           
  Lines        6148     6148           
=======================================
  Hits         5552     5552           
  Misses        596      596

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamgayoso adamgayoso requested a review from wukathy April 6, 2021 01:13
wukathy
wukathy approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@wukathy wukathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamgayoso adamgayoso merged commit f3a1080 into master Apr 6, 2021
@adamgayoso adamgayoso deleted the michael/tonumpy branch April 6, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wukathy wukathy wukathy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use .numpy() to make torch into numpy instead of np.array() constructor
3 participants
@mjayasur @wukathy @adamgayoso