solo enhancements #1009
Merged
solo enhancements #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
+ Coverage 90.38% 90.41% +0.03%
==========================================
Files 90 90
Lines 6562 6583 +21
==========================================
+ Hits 5931 5952 +21
Misses 631 631 ☔ View full report in Codecov by Sentry. |
njbernstein
reviewed
May 17, 2021
| @@ -257,20 +345,29 @@ def auto_forward(module, x): | |||
| for _, tensors in enumerate(scdl): | |||
| x = tensors[_CONSTANTS.X_KEY] | |||
| pred = auto_forward(self.module, x) | |||
| if not soft: | |||
There was a problem hiding this comment.
@adamgayoso why did you remove this?
There was a problem hiding this comment.
Finally getting back to work on things. So hopefully I can get that tutorial out soon
njbernstein
reviewed
May 17, 2021
| preds, columns=cols, index=self.adata.obs_names[singlet_mask] | ||
| ) | ||
|
|
||
| if soft: |
There was a problem hiding this comment.
ahh I see. shouldn't this be if not soft?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1008