Skip to content

Commit f76e192

Browse files
committed
Sets other useful labels, for #78 and #56
1 parent 8811b02 commit f76e192

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

kafka/10broker-config.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ data:
2121
sed -i "s/#init#broker.rack=#init#/#init#broker.rack=# zone label not found for node $NODE_NAME/" /etc/kafka/server.properties
2222
else
2323
sed -i "s/#init#broker.rack=#init#/broker.rack=$ZONE/" /etc/kafka/server.properties
24+
kubectl -n $POD_NAMESPACE label pod $POD_NAME kafka-broker-rack=$ZONE
2425
fi
2526
2627
kubectl -n $POD_NAMESPACE label pod $POD_NAME kafka-broker-id=$KAFKA_BROKER_ID
@@ -29,8 +30,10 @@ data:
2930
if [ $? -ne 0 ]; then
3031
echo "Outside (i.e. cluster-external access) host lookup command failed"
3132
else
32-
OUTSIDE_HOST=${OUTSIDE_HOST}:3240${KAFKA_BROKER_ID}
33-
sed -i "s|#init#advertised.listeners=OUTSIDE://#init#|advertised.listeners=OUTSIDE://${OUTSIDE_HOST}|" /etc/kafka/server.properties
33+
OUTSIDE_PORT=3240${KAFKA_BROKER_ID}
34+
sed -i "s|#init#advertised.listeners=OUTSIDE://#init#|advertised.listeners=OUTSIDE://${OUTSIDE_HOST}:${OUTSIDE_PORT}|" /etc/kafka/server.properties
35+
kubectl -n $POD_NAMESPACE label pod $POD_NAME kafka-listener-outside-host=$OUTSIDE_HOST
36+
kubectl -n $POD_NAMESPACE label pod $POD_NAME kafka-listener-outside-port=$OUTSIDE_PORT
3437
fi
3538
}
3639

rbac-namespace-default/pod-labler.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
# To see if init containers need RBAC:
22
#
3-
# $ kubectl exec kafka-0 -- cat /etc/kafka/server.properties | grep broker.rack
4-
# #init#broker.rack=# zone lookup failed, see -c init-config logs
5-
# $ kubectl logs -c init-config kafka-0
6-
# ++ kubectl get node some-node '-o=go-template={{index .metadata.labels "failure-domain.beta.kubernetes.io/zone"}}'
7-
# Error from server (Forbidden): User "system:serviceaccount:kafka:default" cannot get nodes at the cluster scope.: "Unknown user \"system:serviceaccount:kafka:default\""
3+
# $ kubectl -n kafka logs kafka-2 -c init-config
4+
# ...
5+
# + kubectl -n kafka label pod kafka-2 kafka-broker-id=2
6+
# Error from server (Forbidden): pods "kafka-2" is forbidden: User "system:serviceaccount:kafka:default" cannot get pods in the namespace "kafka": Unknown user "system:serviceaccount:kafka:default"
87
#
98
---
109
kind: Role

0 commit comments

Comments
 (0)