Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for post type without Yoast SEO Metabox #88

Open
kraftner opened this issue Oct 18, 2017 · 0 comments · May be fixed by #103
Open

Add test for post type without Yoast SEO Metabox #88

kraftner opened this issue Oct 18, 2017 · 0 comments · May be fixed by #103
Assignees
@kraftner
Labels
enhancement

Comments

@kraftner
Copy link
Contributor

#67 should have fixed this but some tests to cover our back for regressions wouldn't harm.

I think the general idea would be to add a custom CPT like this:

$args = array(
   'public' => false,
   'show_ui' => true,
   'label'  => 'Test No Metabox'
);
register_post_type( 'test_no_metabox', $args );

from here

yoast-acf-analysis/inc/class-ac-yoast-acf-content-analysis.php

Lines 84 to 87 in 7e3df0c

public function boot_dev() {
$version = ( -1 === version_compare( get_option( 'acf_version' ), 5 ) ) ? '4' : '5';
require_once AC_SEO_ACF_ANALYSIS_PLUGIN_PATH . '/tests/js/system/data/acf' . $version . '.php';
}

And then run a simple test on that CPT.
@kraftner kraftner self-assigned this Oct 18, 2017
@kraftner kraftner linked a pull request Oct 19, 2017 that will close this issue
Open
@andizer andizer assigned andizer and unassigned kraftner Oct 20, 2017
@andizer andizer added queue and removed code-review labels Oct 20, 2017
@andizer andizer assigned kraftner and unassigned andizer Oct 20, 2017
@jcomack jcomack self-assigned this Oct 24, 2017
@jcomack jcomack removed their assignment Oct 24, 2017
@jcomack jcomack assigned jcomack and unassigned jcomack Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kraftner kraftner

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure no errors on CPTs without Yoast SEO metabox Yoast/yoast-acf-analysis
4 participants
@andizer @moorscode @kraftner @jcomack