Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook to exlude taxonomies on post republish #244

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

benbchd
Copy link

@benbchd benbchd commented Apr 6, 2022

Context

Summary

This PR can be summarized in the following changelog entry:

  • changelog: enhancement

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@xipasduarte
Copy link

Hi @benbchd we needed a similar change and added a filter on the other use of use_filters. I'd like to suggest a change in your filter name for better consistency with the rest of the plugin: duplicate_post_republish_post_taxonomies_use_filters

Either way, let's see what the maintainers have in mind, before committing to a name 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants