Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number constant #46

Closed
1 task done
jrfnl opened this issue Aug 9, 2021 · 0 comments · Fixed by #47
Closed
1 task done

Add version number constant #46

jrfnl opened this issue Aug 9, 2021 · 0 comments · Fixed by #47

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Aug 9, 2021

In select cases, it may be useful for a version number constant to be available to test suites integrating the polyfills.

Proposal:

  • Add a VERSION constant to the Autoload class or a namespaced constant declared in the autoload file.

Would also be nice to add a CI check to safeguard that this is updated on every release, as that's easily forgotten.
Something like "for a PR to master, grab the top-most version number from the changelog.md file and verify that it is the same as the one used in the autoload file".

At the very least, the repo should start working with a release checklist which includes a check for version number being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant