Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making errors nullable #44

Closed
ElectroJr opened this issue Dec 23, 2023 · 1 comment · Fixed by #50
Closed

Consider making errors nullable #44

ElectroJr opened this issue Dec 23, 2023 · 1 comment · Fixed by #50

Comments

@ElectroJr
Copy link
Contributor

Currently trying to resolve a message will always allocate a List<FluentError>, which is unnecessary in the majority of instances.
@Ygg01
Copy link
Owner

Ygg01 commented Dec 24, 2023

Sounds good to me but requires breaking API.

@Ygg01 Ygg01 mentioned this issue Jan 9, 2024
Merged
@Ygg01 Ygg01 closed this as completed in #50 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make FluentBundle abstract and do some API refactoring Ygg01/Linguini
2 participants
@Ygg01 @ElectroJr