Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for moshi-reflective approach #83

Closed
3 tasks
macisamuele opened this issue Jan 22, 2020 · 1 comment · Fixed by #127
Closed
3 tasks

Remove support for moshi-reflective approach #83

macisamuele opened this issue Jan 22, 2020 · 1 comment · Fixed by #127
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@macisamuele
Copy link
Collaborator

PR #82 has added support for code-generated Moshi Adapters.
As result of the discussion on the PR we need clear up the current mixed support of reflective and moshi-codegen approach.

We need to do it in order to:

  • reduce complexity
  • reduce dependencies (as mentioned in Add support for moshi-kotlin-codegen #62 moshi-kotlin depends on kotlin-reflect which is pretty big)
  • provide better performances with the least surprises for user

In order to achieve such objective we need to:

  • Remove kotlin-android-with-moshi-kotlin-codegen and update kotlin-android to use only moshi-kotlin-codegen
  • Update groovy-android
  • Improve documentation to highlight a possible approach to still use reflective approach (a way to rebuild GeneratedCodeConverters.moshi)

Disclaimer: The list is not supposed to be complete, so if I'm missing something please update the checklist ;)

@macisamuele macisamuele added this to the 2.0.0 milestone Jan 22, 2020
@cortinico
Copy link
Collaborator

As a side note: it's probably worth to investigate a bit around https://github.com/Kotlin/kotlinx.reflect.lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants