Auto Create 'tracked' Directory #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time today trying to setup detect-secrets-server and ran into some issues. I'm using s3 for storage and running inside a Bamboo build environment. I added the tracked repositories on my dev machine, and then tried to run the tool in Bamboo.
I kept getting this error, no matter if I manually set the root directory or not.
After debugging locally, I realized that the
trackedsubdirectory wasn't being created automatically. It seems like this dir only gets created when adding a repo. This PR adds additional logging, and tries to create the directory if it doesn't exist. If thetrackeddirectory doesn't exist, all files downloaded from s3 will fail to save locally.I know this tool is setup to use cron, but apart from small gaps like this, there is very little to hold others back from using s3 and running the tool on an ephemeral instance. Thanks for all of your work building this great tool!