Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Extract pragmas #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

francisluz
Copy link

πŸ—’οΈ Description
As a detect-secrets-server user, I would like to extract all pragmas in my codebase where I can validate the use of pragma: allowlist secrets.

πŸ’‘ Solution
Using the current process that loop through the code and plugin, one more step was added to extract the pragmas. This is an optional feature where on the server side will be triggered through a new flag called --extract-pragmas.

βŒ› Time complexity
The performance impact on the scan if this feature is enabled, will be O(n+1) where extract-pragmas is considered an extra plugin run.

πŸ”΄ Unit Test
There are unit tests failing that I didn't manage to fix yet, as it was there already.

😎 Hope you guys like this feature, we're already using it in our internal CI process.
πŸ‘ Feel free to reach me out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant