Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST interface drops optimization_parameters data on the floor #106

Closed
suntzu86 opened this issue Jun 1, 2014 · 0 comments · Fixed by #116
Closed

REST interface drops optimization_parameters data on the floor #106

suntzu86 opened this issue Jun 1, 2014 · 0 comments · Fixed by #116

Comments

@suntzu86
Copy link
Contributor

suntzu86 commented Jun 1, 2014

BLOCKING: GH-97

Looks like the REST interface drops optimization_parameters data on the floor. The dict

TODO:

  1. I think moe.views.schemas.OptimizationInfo class needs to have optimization_parameters field added as a schemanode--just a dumb 'dict' node that doesn't do any validation.

  2. Also, the comments for OptimizationInfo are out of date.

  3. Since the the webserver is mocked (self.testapp), we should have access to all the data we pass through the POST. So maybe btwn these lines

resp = self.testapp.post(moe_route.endpoint, json_payload)
resp_schema = GpNextPointsResponse()

We should test that the information deserialized from the post request is what we expect. This might not be the right place for this test but something along these lines should be checked.
Related Issue: GH-97

  1. Maybe the deserializers should complain about any unexpected/non-understood data?

NOTE:
When you make this change, the gp_next_points test will start using very different gradient descent parameters (TEST_ instead of DEFAULT_). This may cause the tests to fail or do nothing useful--TEST_ defaults may need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants