Tighten up expected exceptions to avoid false positives

Author: James Couball

lib/mysql_expectations/key_field.rb

@@ -45,15 +45,15 @@ def validate_length(length)
       begin
         length = Integer(length)
       rescue ArgumentError
-        raise 'length must be an integer or convertable to an integer'
+        raise ArgumentError.new('length must be an integer or convertable to an integer')
       end
       length
     end
 
     def validate_order(order)
       return nil if order.nil?
       return order if VALID_ORDERINGS.include? order
-      fail 'Order must be either KeyField::ORDER_ASC or KeyField::ORDER_DESC'
+      fail ArgumentError.new('Order must be either KeyField::ORDER_ASC or KeyField::ORDER_DESC')
     end
   end
 end

spec/database_spec.rb

@@ -29,10 +29,10 @@
         expect(subject.item).to be_an_instance_of(Table)
       end
       it 'should raise an exception when called with args' do
-        expect { subject.item(1) }.to raise_error
+        expect { subject.item(1) }.to raise_error NoMethodError
       end
       it 'should raise an exception when called with a block' do
-        expect { subject.item {} }.to raise_error
+        expect { subject.item {} }.to raise_error NoMethodError
       end
     end
 

spec/key_field_spec.rb

@@ -84,7 +84,7 @@
     it 'should throw an exception during initialization' do
       expect do
         KeyField.new('id', :asdf)
-      end.to raise_error
+      end.to raise_error ArgumentError
     end
   end
 
@@ -100,7 +100,7 @@
     it 'should not throw an error during initialization' do
       expect do
         KeyField.new('id', KeyField::ORDER_ASC, 'forty')
-      end.to raise_error
+      end.to raise_error ArgumentError
     end
   end
 end

spec/mysql_spec.rb

@@ -26,10 +26,10 @@
         )
       end
       it 'should raise an exception when called with args' do
-        expect { subject.order_tracking(1) }.to raise_error
+        expect { subject.order_tracking(1) }.to raise_error NoMethodError
       end
       it 'should raise an exception when called with a block' do
-        expect { subject.order_tracking {} }.to raise_error
+        expect { subject.order_tracking {} }.to raise_error NoMethodError
       end
     end
 

spec/table_spec.rb

@@ -45,10 +45,10 @@
         expect(subject.id).to be_an_instance_of(Field)
       end
       it 'should raise an exception when called with args' do
-        expect { subject.id(1) }.to raise_error
+        expect { subject.id(1) }.to raise_error NoMethodError
       end
       it 'should raise an exception when called with a block' do
-        expect { subject.id {} }.to raise_error
+        expect { subject.id {} }.to raise_error NoMethodError
       end
     end