New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel region update immediately on error #404

Open

paetz opened this issue Feb 11, 2023 · 0 comments

Labels

feature

Collaborator

paetz commented Feb 11, 2023 •

edited

Loading

Current update behavior is like this:
If an error occurs, do not parse anymore but wait for all network requests to be executed.

It would be more efficient to cancel the network threads on error immediately.
Possible problems:

Can we cancel a coroutine from inside?
Cancelling a coroutine just sends a cancel request to the threads. It might be possible that the receiving & enqueuing coroutines still work for the old region while a new region's update has already been started (in case of "Update all")

paetz added the feature label

paetz added this to the v0.8.0 milestone

paetz removed this from the v0.8.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment