Improve docId getter and documentation (smithy-lang#1872)

jvschneid · Steven Yuan · commit b587e36cf3d3 · 2023-08-10T17:25:48.000-07:00
diff --git a/docs/source-1.0/spec/aws/aws-core.rst b/docs/source-1.0/spec/aws/aws-core.rst
@@ -240,7 +240,7 @@ need to explicitly configure the ``cloudTrailEventSource`` setting.
 .. _service-doc-id:
 
 ``docId``
-===========================
+=========
 
 The ``docId`` property is a ``string`` value that is used to implement linking
 between service and SDK documentation for AWS services.
diff --git a/docs/source-2.0/aws/aws-core.rst b/docs/source-2.0/aws/aws-core.rst
@@ -200,7 +200,7 @@ need to explicitly configure the ``cloudTrailEventSource`` setting.
 .. _service-doc-id:
 
 ``docId``
-===========================
+=========
 
 The ``docId`` property is a ``string`` value that is used to implement linking
 between service and SDK documentation for AWS services.
diff --git a/smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ServiceTrait.java b/smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/ServiceTrait.java
@@ -158,7 +158,7 @@ public String getCloudTrailEventSource() {
      * @return Returns the documentation identifier value for the service name.
      */
     public String getDocId(Model model) {
-        return getDocId().orElse(buildDefaultDocId(model));
+        return getDocId().orElseGet(() -> buildDefaultDocId(model));
     }
 
     protected Optional<String> getDocId() {

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ public String getCloudTrailEventSource() {`
`158`	`158`	`* @return Returns the documentation identifier value for the service name.`
`159`	`159`	`*/`
`160`	`160`	`public String getDocId(Model model) {`
`161`		`- return getDocId().orElse(buildDefaultDocId(model));`
	`161`	`+ return getDocId().orElseGet(() -> buildDefaultDocId(model));`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`protected Optional<String> getDocId() {`