Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call() does not preserve float registers #17

Open
JayFoxRox opened this issue Jul 2, 2018 · 0 comments
Open

call() does not preserve float registers #17

JayFoxRox opened this issue Jul 2, 2018 · 0 comments

Comments

@JayFoxRox
Copy link
Member

If you intend to use floats in your calls, you have to manually clean-up and restore.

It has not been decided what the final calling convention for our call() is.
For now, assume that you always have to clean up the FPU, and this is a documentation issue.

There sould be a comment in the code, or some docs which make this clear. The GitHub issue is a temporary measure.
Alternatively, if you feel strongly about this, you can implement float cleanup. But I personally believe it would overcomplicate an already complicated assembler function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant