Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port libfmt #594

Closed
glebm opened this issue Jul 1, 2022 · 3 comments
Closed

Port libfmt #594

glebm opened this issue Jul 1, 2022 · 3 comments

Comments

@glebm
Copy link
Contributor

glebm commented Jul 1, 2022

Several of the winapi issues I filed today are coming from libfmt, a rather ubiqitous C++ library these days.

These issues happen because NXDK defines _WIN32, which makes the library assume WIN32 API support (and rightly so).

Should NXDK stop defining _WIN32? If not, should a patched libfmt be available as one of the SDK libraries?

@glebm
Copy link
Contributor Author

glebm commented Jul 2, 2022

I'd be happy to port it (i.e. sprinkle !defined(NXDK) throughout) if that's the right answer.

Can you please fork https://github.com/fmtlib/fmt into the XboxDev org and give me permissions for the fork?

@glebm
Copy link
Contributor Author

glebm commented Jul 2, 2022

I've got a branch that builds with NXDK here: https://github.com/glebm/fmt/tree/nxdk

@glebm
Copy link
Contributor Author

glebm commented Jul 16, 2022

We now maintain our own port here: https://github.com/diasurgical/fmt/tree/nxdk-2022-07-19

Feel free to use it from your projects

@glebm glebm closed this as completed Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant