-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Is XGU planned to be implemented in master for nxdk #480
Comments
I think we should slim nxdk down to where it's only a core C/C++ toolchain without much else. Therefore, I don't think XGU should be part of the core nxdk (for now). If people care about XGU, they should improve it: core tech, but also how it can be deployed / installed. Also, promoting a rather unfinished submodule and repeatedly updating submodules (whenever XGU improves) doesn't sound like a good idea to me. Promoting XGU by making it a submodule of nxdk might also discourage exploring other options to utilize the GPU. While XGU is much more usable than pbkit, it is still buggy and it's currently impossible to do a lot of really important stuff. At this point, I don't even like inclusion of pbkit in nxdk anymore (which also leads to situations like https://github.com/XboxDev/nxdk-sdl/pull/37 which only prolong the life of poor APIs like pbkit). While I'd probably use that SDL branch in some projects, I don't think it's good to add more dependencies on pbkit; adding XGU would be a similar case. We also had discussions about maintaining ports in #418 and #432. So, until XGU has matured, you should just submodule XGU in your projects (not in nxdk) and improve XGU at dracc/xgu - I don't think submoduling it in your project is hacky at all. It ensures that your project always uses the correct version. Lastly, the primary user of XGU are probably XGU samples (by Voxel and me) + xgu-gl (which must be tweaked per project anyway). |
Thanks for the quick reply, and yes I understand that it is probably better streamline nxdk into just being a toolchain and not much else and leaving it as a place for developers to build off of, and implement their own libraries and submodules. I also do believe the pbkit is a rather poor API, and I only real "reason" I have used it isn't using it by itself, it is using XGU samples to test certain situations in xemu to test changes to nv2a. Now that this has been said, I think fixing nxdk's building system is definitely something should (and is) being worked on and our daily banter in the xboxdev discord about merging nxdk#438, nxdk-sdl#38, and nxdk#421. However, thank you for the detailed response and it has helped me understand more of your reasoning on the matter, I greatly appreciate it! |
Asking as my use of https://github.com/dracc/xgu submodule is rather hacky and it would be better if it was a legitimate submodule in nxdk.
The text was updated successfully, but these errors were encountered: