Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance hook: Votes of removed members are not purged #211

Open
ihomp opened this issue Nov 18, 2023 · 0 comments · May be fixed by #221
Open

Governance hook: Votes of removed members are not purged #211

ihomp opened this issue Nov 18, 2023 · 0 comments · May be fixed by #221
Labels
fix Bug Fix High High Priority Bug (should be fixed immediately for next release)

Comments

@ihomp
Copy link

ihomp commented Nov 18, 2023

Issue Description

When Table members are removed from the table, their votes are still counted in the vote count.

Steps to Reproduce

  • Cast votes from L2 table members
  • Replace members with new ones
    For example table with 2 seats: 0 and 1
    0 seat vote to place rNewAddress0 to place 0 (its own place)
    0 seat vote to place rNewAddress1 to place 1
    1 seat vote to place rNewAddress0 to place 0 (0 seat gets replaced)
    1 seat vote to place rNewAddress1 to place 1 (its own place) (1st seat gets replaced)

Expected Result

I would expect the votes from removed members not to be included in the Votes Count.

Actual Result

The vote list and the vote count keep the votes from removed members

Environment

Hook: 78CA3F5BD3D4F7B32A6BEBB3844380A9345C9BA496EFEB30314BDDF405D7B4B3
Testnet

Supporting Files

https://test.xahauexplorer.com/governance/roUo3ygV92bdhfE1v9LGpPETXvJv2kQv5
@RichardAH RichardAH added the High High Priority Bug (should be fixed immediately for next release) label Nov 23, 2023
tequdev added a commit to tequdev/xahaud that referenced this issue Nov 28, 2023
@tequdev
fix governance vote purge (Xahau#211)
4e09381
@tequdev tequdev linked a pull request Nov 28, 2023 that will close this issue
Open
@dangell7 dangell7 added the fix Bug Fix label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Bug Fix High High Priority Bug (should be fixed immediately for next release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix governance vote purge tequdev/xahaud
3 participants
@ihomp @RichardAH @dangell7