Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Toggle executions #86

Closed
Xabaril opened this issue Jan 20, 2020 · 0 comments
Closed

Improve Toggle executions #86

Xabaril opened this issue Jan 20, 2020 · 0 comments
Assignees
Labels
Core enhancement New feature or request
Milestone

Comments

@Xabaril
Copy link
Collaborator

Xabaril commented Jan 20, 2020

At this moment, the base contract for IToggle depends on IRuntimeFeatureStore to get all the configuration data from the store. This is a hard dependency for implementors and also imply many store queries for each feature.
DefaultFeatureService do this query and can get all the execution context to check if toggle is active or not.

The proposal is create a new abstraction like ToggleExecutionContext and pass this to all IToggle with the enought information to evaluate toggles.

@Xabaril Xabaril added the Core label Jan 20, 2020
@Xabaril Xabaril added this to the Future milestone Jan 20, 2020
@unaizorrilla unaizorrilla modified the milestones: Future, Esquio-3 Jan 28, 2020
@unaizorrilla unaizorrilla added the enhancement New feature or request label May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant