You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
In the Python codebase, api_version is set inside the Request class, it is not a part of the Client class.
These Request(-child) instances do not persist between RPC invocations, so the above idea cannot be achieved in xrpl-py.
rippled structures all the RPC requests with individual api_version fields. I mirrored that level of granularity in the Python SDK. Is this a pressing issue?
Let me think of a solution that doesn't change the architecture substantially :)
Hello, I acknowledge that there is no "default setting" for the api_version value in xrpl-py's Client class. This is also true for clients communicating with rippled directly via JSON-RPC or WebSocket connections.
If you have any use-cases which are hindered by this design, please let me know.
I'm happy to review any code-suggestions pertaining to this issue, however I cannot take this up at the moment.
The following processes that are possible in xrpl.js should also be possible in xrpl-py.
The text was updated successfully, but these errors were encountered: