Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Replace Uint192 with Hash192 in server_definitions response #5177

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

shawnxie999
Copy link
Collaborator

@shawnxie999 shawnxie999 commented Nov 1, 2024

High Level Overview of Change

All base_uint types are returned with "Hash" prefix in server_definitions response except for Uint192.

Context of Change

Before


"TYPES": {
    "AccountID": 8,
    "Amount": 6,
    "Blob": 7,
    "Currency": 26,
    "Done": -1,
    "Hash128": 4,
    "Hash160": 17,
    "Hash256": 5,
    "Issue": 24,
    "LedgerEntry": 10002,
    "Metadata": 10004,
    "NotPresent": 0,
    "PathSet": 18,
    "STArray": 15,
    "STObject": 14,
    "Transaction": 10001,
    "UInt16": 1,
    "Uint192": 21, //wrong
    "UInt32": 2,
    "UInt384": 22,
    "UInt512": 23,
    "UInt64": 3,
    "UInt8": 16,
    "UInt96": 20,
    "Unknown": -2,
    "Validation": 10003,
    "Vector256": 19,
    "XChainBridge": 25
  }

After:

 "TYPES": {
            "AccountID": 8,
            "Amount": 6,
            "Blob": 7,
            "Currency": 26,
            "Done": -1,
            "Hash128": 4,
            "Hash160": 17,
            "Hash192": 21, //correct
            "Hash256": 5,
            "Issue": 24,
            "LedgerEntry": 10002,
            "Metadata": 10004,
            "NotPresent": 0,
            "PathSet": 18,
            "STArray": 15,
            "STObject": 14,
            "Transaction": 10001,
            "UInt16": 1,
            "UInt32": 2,
            "UInt384": 22,
            "UInt512": 23,
            "UInt64": 3,
            "UInt8": 16,
            "UInt96": 20,
            "Unknown": -2,
            "Validation": 10003,
            "Vector256": 19,
            "XChainBridge": 25
        }

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (c5c0e70) to head (b1e03ec).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5177     +/-   ##
=========================================
+ Coverage     77.7%   77.9%   +0.2%     
=========================================
  Files          779     782      +3     
  Lines        66015   66615    +600     
  Branches      8156    8140     -16     
=========================================
+ Hits         51261   51886    +625     
+ Misses       14754   14729     -25     
Files with missing lines Coverage Δ
src/xrpld/rpc/handlers/ServerInfo.cpp 97.7% <100.0%> (+<0.1%) ⬆️

... and 14 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez added the Blocked label Nov 4, 2024
@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Nov 6, 2024
@ximinez ximinez merged commit 7b18006 into XRPLF:develop Nov 6, 2024
17 of 18 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants