Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes small typos in RELEASENOTES.md #5154

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

NicholasWilsonDEV
Copy link
Contributor

I really enjoyed using this project, nice work! Found a typo in RELEASENOTES.md though 😛

Fix the typo "concensus" -> "consensus"

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

fix the typo "concensus" -> "consensus"
@Bronek Bronek added Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial labels Oct 17, 2024
@ximinez ximinez merged commit ab5d450 into XRPLF:develop Oct 29, 2024
18 checks passed
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.5%. Comparing base (23c37fa) to head (96a492e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5154   +/-   ##
=======================================
  Coverage     77.5%   77.5%           
=======================================
  Files          777     777           
  Lines        65829   65829           
  Branches      8189    8186    -3     
=======================================
+ Hits         51012   51021    +9     
+ Misses       14817   14808    -9     

see 3 files with indirect coverage changes

Impacted file tree graph

vlntb pushed a commit to vlntb/rippled that referenced this pull request Nov 19, 2024
fix the typo "concensus" -> "consensus"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants