Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed version 2.2.1 #5078

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Proposed version 2.2.1 #5078

merged 3 commits into from
Jul 29, 2024

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Jul 29, 2024

High Level Overview of Change

This is a hotfix release that fixes a critical bug (introduced in 2.2.0) handling some types of RPC requests.

The base branch is master. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to master, and reverse-merged to develop. Do not use the Github UI to merge this PR

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Release

@ximinez ximinez added Bug Perf impact not expected Change is not expected to improve nor harm performance. labels Jul 29, 2024
@ximinez ximinez requested review from mtrippled and mvadari July 29, 2024 16:45
Copy link
Collaborator

@mtrippled mtrippled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jul 29, 2024
@ximinez ximinez merged commit e6ef0fc into XRPLF:master Jul 29, 2024
16 of 17 checks passed
@ximinez ximinez deleted the pr/errorhandling branch July 29, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Perf impact not expected Change is not expected to improve nor harm performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants