Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CTID in tx command returns invalidParams on lowercase hex #5049

Merged
merged 7 commits into from
Jul 5, 2024
Merged

fix CTID in tx command returns invalidParams on lowercase hex #5049

merged 7 commits into from
Jul 5, 2024

Conversation

yinyiqian1
Copy link
Collaborator

fix #4776

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@shawnxie999 shawnxie999 self-requested a review June 20, 2024 14:41
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.4%. Comparing base (a17ccca) to head (7da5cdd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5049   +/-   ##
=======================================
  Coverage     71.4%   71.4%           
=======================================
  Files          796     796           
  Lines        67031   67031           
  Branches     10864   10863    -1     
=======================================
  Hits         47834   47834           
  Misses       19197   19197
Files Coverage Δ
src/xrpld/rpc/CTID.h 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

shawnxie999
shawnxie999 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@shawnxie999 shawnxie999 requested a review from scottschurr June 24, 2024 15:13
@yinyiqian1 yinyiqian1 assigned yinyiqian1 and unassigned yinyiqian1 Jun 26, 2024
scottschurr
scottschurr approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, and thanks for including a test that exercises the new case.

I left some comments about things that, in my opinion, would improve the unit test. But they are at your discretion.

src/ripple/rpc/CTID.h Outdated Show resolved Hide resolved
src/test/rpc/Transaction_test.cpp Outdated Show resolved Hide resolved
src/test/rpc/Transaction_test.cpp Outdated Show resolved Hide resolved
src/test/rpc/Transaction_test.cpp Outdated Show resolved Hide resolved
src/test/rpc/Transaction_test.cpp Outdated Show resolved Hide resolved
@yinyiqian1 yinyiqian1 requested a review from scottschurr July 3, 2024 17:14
scottschurr
scottschurr approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple more nits in the most recent changes to the test. But, again, nothing that should hold up merging.

src/test/rpc/Transaction_test.cpp Outdated Show resolved Hide resolved
src/test/rpc/Transaction_test.cpp Outdated Show resolved Hide resolved
scottschurr
scottschurr approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scottschurr
Copy link
Collaborator

@yinyiqian1, this pull request has two approvals. Are you ready for the pull request to be marked as passed? Let me know. Thanks.

@yinyiqian1
Copy link
Collaborator Author

@yinyiqian1, this pull request has two approvals. Are you ready for the pull request to be marked as passed? Let me know. Thanks.

@scottschurr Yes. It can be marked as passed. Thank you Scott.

@zrayn zrayn added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jul 5, 2024
@zrayn zrayn merged commit 0f32109 into XRPLF:develop Jul 5, 2024
18 of 19 checks passed
vlntb pushed a commit to vlntb/rippled that referenced this pull request Aug 23, 2024
@yinyiqian1 @zrayn @vlntb
fix CTID in tx command returns invalidParams on lowercase hex (XRPLF#…
4d230a8 
…5049)

* fix CTID in tx command returns invalidParams on lowercase hex

* test mixed case and change auto to explicit type

* add header cctype because std::tolower is called

* remove unused local variable

* change test case comment from 'lowercase' to 'mixed case'

---------

Co-authored-by: Zack Brunson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnxie999 shawnxie999 shawnxie999 approved these changes

@scottschurr scottschurr scottschurr approved these changes

Assignees
No one assigned
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTID in tx command returns invalidParams on lowercase hex
4 participants
@yinyiqian1 @scottschurr @shawnxie999 @zrayn