From 5aa1106ba1fe25ee26dae34feeeed2136ba21bd7 Mon Sep 17 00:00:00 2001 From: seelabs Date: Wed, 1 May 2024 11:40:06 -0400 Subject: [PATCH] Remove flow assert: (#5009) Rounding in the payment engine is causing an assert to sometimes fire with "dust" amounts. This is causing issues when running debug builds of rippled. This issue will be addressed, but the assert is no longer serving its purpose. --- src/ripple/app/paths/impl/StrandFlow.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ripple/app/paths/impl/StrandFlow.h b/src/ripple/app/paths/impl/StrandFlow.h index 7817251560f..2df496d8311 100644 --- a/src/ripple/app/paths/impl/StrandFlow.h +++ b/src/ripple/app/paths/impl/StrandFlow.h @@ -834,7 +834,13 @@ flow( { if (actualOut > outReq) { - assert(0); + // Rounding in the payment engine is causing this assert to + // sometimes fire with "dust" amounts. This is causing issues when + // running debug builds of rippled. While this issue still needs to + // be resolved, the assert is causing more harm than good at this + // point. + // assert(0); + return {tefEXCEPTION, std::move(ofrsToRmOnFail)}; } if (!partialPayment)