Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] fix: Remove redundant STAmount conversion in test #4996

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Apr 19, 2024

Does what it says on the tin.

Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on macOS with Apple clang version 13.1.6 (clang-1316.0.21.2.5) and warnings-as-errors.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.0%. Comparing base (cd737ad) to head (9c7e459).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4996   +/-   ##
=======================================
  Coverage     70.9%   71.0%           
=======================================
  Files          796     796           
  Lines        66727   66727           
  Branches     10977   10973    -4     
=======================================
+ Hits         47337   47346    +9     
+ Misses       19390   19381    -9     

see 2 files with indirect coverage changes

Impacted file tree graph

@ximinez ximinez merged commit f20e66e into XRPLF:develop Apr 19, 2024
17 checks passed
@ximinez ximinez deleted the pr/stamount_quickfix branch April 19, 2024 01:09
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants