Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] chore: fix typos in comments #4958

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

xiaoxianBoy
Copy link
Contributor

@xiaoxianBoy xiaoxianBoy commented Mar 20, 2024

High Level Overview of Change

Context of Change

fix minor typos

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@Bronek Bronek changed the title chore: fix typos [TRIVIAL] chore: fix typos in comments Apr 11, 2024
@Bronek
Copy link
Collaborator

Bronek commented Apr 11, 2024

@xiaoxianBoy thank you for this PR ; as you will notice I have changed its subject line to indicate that it's trivial; and the type of the change.

@Bronek Bronek requested a review from scottschurr April 11, 2024 10:18
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.9%. Comparing base (e9859ac) to head (81e6a03).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #4958   +/-   ##
=======================================
  Coverage     70.9%   70.9%           
=======================================
  Files          796     796           
  Lines        66727   66727           
  Branches     10977   10975    -2     
=======================================
+ Hits         47337   47339    +2     
+ Misses       19390   19388    -2     
Files Coverage Δ
src/ripple/app/misc/TxQ.h 98.1% <ø> (ø)
src/ripple/app/paths/impl/Steps.h 93.1% <ø> (ø)
src/ripple/app/reporting/ETLSource.cpp 0.0% <ø> (ø)
src/ripple/app/tx/impl/NFTokenAcceptOffer.cpp 89.6% <ø> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catches. Thanks for the contribution!

@thejohnfreeman thejohnfreeman added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 25, 2024
@thejohnfreeman thejohnfreeman merged commit b422e71 into XRPLF:develop Apr 25, 2024
17 checks passed
legleux added a commit to legleux/rippled that referenced this pull request Apr 26, 2024
* Remove unused files

* Remove packaging scripts

* Consolidate external libraries

* Simplify protobuf generation

* Rename .hpp to .h

* Format formerly .hpp files

* Rewrite includes

$ find src/ripple/ src/test/ -type f -exec sed -i 's:include\s*["<]ripple/\(.*\)\.h\(pp\)\?[">]:include <ripple/\1.h>:' {} +

* Fix source lists

* Add markers around source lists

* Address compiler warnings

* Ignore more commits

* test: Add RPC error checking support to unit tests (XRPLF#4987)

* chore: fix typos (XRPLF#4958)

* file

* new commit

* file sucks

---------

Co-authored-by: John Freeman <[email protected]>
Co-authored-by: Pretty Printer <[email protected]>
Co-authored-by: Ed Hennis <[email protected]>
Co-authored-by: Snoppy <[email protected]>
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants