-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRIVIAL] chore: fix typos in comments #4958
Conversation
@xiaoxianBoy thank you for this PR ; as you will notice I have changed its subject line to indicate that it's trivial; and the type of the change. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4958 +/- ##
=======================================
Coverage 70.9% 70.9%
=======================================
Files 796 796
Lines 66727 66727
Branches 10977 10975 -2
=======================================
+ Hits 47337 47339 +2
+ Misses 19390 19388 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good catches. Thanks for the contribution!
* Remove unused files * Remove packaging scripts * Consolidate external libraries * Simplify protobuf generation * Rename .hpp to .h * Format formerly .hpp files * Rewrite includes $ find src/ripple/ src/test/ -type f -exec sed -i 's:include\s*["<]ripple/\(.*\)\.h\(pp\)\?[">]:include <ripple/\1.h>:' {} + * Fix source lists * Add markers around source lists * Address compiler warnings * Ignore more commits * test: Add RPC error checking support to unit tests (XRPLF#4987) * chore: fix typos (XRPLF#4958) * file * new commit * file sucks --------- Co-authored-by: John Freeman <[email protected]> Co-authored-by: Pretty Printer <[email protected]> Co-authored-by: Ed Hennis <[email protected]> Co-authored-by: Snoppy <[email protected]>
High Level Overview of Change
Context of Change
fix minor typos
Type of Change
.gitignore
, formatting, dropping support for older tooling)