Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: crash when rendering JSON binary transaction with API v.2 enabled #4811

Closed
Bronek opened this issue Nov 13, 2023 · 0 comments · Fixed by #4812
Closed

Regression: crash when rendering JSON binary transaction with API v.2 enabled #4811

Bronek opened this issue Nov 13, 2023 · 0 comments · Fixed by #4812
Milestone

Comments

@Bronek
Copy link
Collaborator

Bronek commented Nov 13, 2023

Issue Description

In PR #4775 the API version 2 output of tx method has significantly changed, and in the process has also the JSON type of output from STTx::getJson . If we enable both API v. 2 and binary output, that JSON is no longer an object but a string. It follows that it cannot have any additional JSON fields added, and yet we try to add fields inside Transaction::getJson which causes a crash.

Steps to Reproduce

Run tx method requesting binary output with api_version 2

Expected Result

Output transaction data with tx_blob field (among others)

Actual Result

Crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants