-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert code base from boost::string_view
to std::string_view
#3435
Comments
@ckeshava could you think about this and let us know your recommendation? Feel free to consult with @scottschurr as needed (he opened the original issue) |
Hello, I believe |
Hi @ckeshava. Thanks for looking into this. In terms of changes, my feeling is that, wherever we can, we should be replacing In terms of replacing In case it's helpful, here is an outstanding review of what should (and should not) be done with I hope that helps. Let me know if you have further questions. |
We will need to finish eliminating |
Issue Description
The codebase currently does not make a lot of use of string_view. Mostly it shows up in the asio facing parts of the code. I tried converting those uses of boost::string_view to std::string_view a few months ago. It almost worked.
There’s a problem in boost 1.70 where in Windows the flag that tells beast to use std::string_view (not boost::string_view) does not work correctly. I understand that particular problem is fixed in Boost 1.71. So once we get to a place where the code base requires boost 1.71 or greater, then I think we can take on this task.
Once we have std::string_view in the code base there are a number of optimizations that can be performed. But I believe it should all start by moving to std::string_view first.
Exported from RIPD-1789
The text was updated successfully, but these errors were encountered: