Skip to content

Commit f4661e0

Browse files
committed
requested changes for PR comments 2
1 parent e3deece commit f4661e0

File tree

3 files changed

+212
-213
lines changed

3 files changed

+212
-213
lines changed

src/ripple/net/impl/RPCCall.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -1355,18 +1355,18 @@ rpcCmdLineToJson (std::vector<std::string> const& args,
13551355
jvRequest = rpParser.parseCommand (args[0], jvRpcParams, true);
13561356

13571357
auto insert_api_version = [](Json::Value & jr){
1358-
if(!jr.isMember(jss::error) && !jr.isMember(jss::api_version))
1358+
if( jr.isObject() &&
1359+
!jr.isMember(jss::error) &&
1360+
!jr.isMember(jss::api_version))
1361+
{
13591362
jr[jss::api_version] = RPC::ApiMaximumSupportedVersion;
1363+
}
13601364
};
13611365

13621366
if(jvRequest.isObject())
13631367
insert_api_version(jvRequest);
1364-
else if(jvRequest.isArray()) {
1365-
for (Json::UInt j = 0; j < jvRequest.size(); ++j) {
1366-
if (jvRequest[j].isObject())
1367-
insert_api_version(jvRequest[j]);
1368-
}
1369-
}
1368+
else if(jvRequest.isArray())
1369+
std::for_each(jvRequest.begin(), jvRequest.end(), insert_api_version);
13701370

13711371
JLOG (j.trace()) << "RPC Request: " << jvRequest << std::endl;
13721372
return jvRequest;

src/ripple/rpc/impl/ServerHandlerImp.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ ServerHandlerImp::processRequest (Port const& port,
614614
if (jsonRPC.isMember(jss::params) &&
615615
jsonRPC[jss::params].isArray() &&
616616
jsonRPC[jss::params].size() > 0 &&
617-
jsonRPC[jss::params][Json::UInt(0)].isObject())
617+
jsonRPC[jss::params][0u].isObject())
618618
{
619619
apiVersion = RPC::getAPIVersionNumber(jsonRPC[jss::params][Json::UInt(0)]);
620620
}

0 commit comments

Comments
 (0)