Skip to content

Commit 053b69c

Browse files
authored
docs(API-CHANGELOG): add XRPFees change (#4741)
* Add a new API Changelog section for release 1.10. * Mark `jss::fee_ref` as deprecated. * Fix a copy-paste error in one of the unit tests.
1 parent ced14ec commit 053b69c

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

API-CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,17 @@ Additions are intended to be non-breaking (because they are purely additive).
9898
- Added `NFTokenPages` to the `account_objects` RPC. (https://github.com/XRPLF/rippled/pull/4352)
9999
- Fixed: `marker` returned from the `account_lines` command would not work on subsequent commands. (https://github.com/XRPLF/rippled/pull/4361)
100100

101+
## XRP Ledger version 1.10.0
102+
103+
[Version 1.10.0](https://github.com/XRPLF/rippled/releases/tag/1.10.0)
104+
was released on Mar 14, 2023.
105+
106+
### Breaking changes in 1.10
107+
108+
- If the `XRPFees` feature is enabled, the `fee_ref` field will be
109+
removed from the [ledger subscription stream](https://xrpl.org/subscribe.html#ledger-stream), because it will no longer
110+
have any meaning.
111+
101112
# In development
102113

103114
Changes below this point are in development.

src/ripple/protocol/jss.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ JSS(fee_base); // out: NetworkOPs
315315
JSS(fee_div_max); // in: TransactionSign
316316
JSS(fee_level); // out: AccountInfo
317317
JSS(fee_mult_max); // in: TransactionSign
318-
JSS(fee_ref); // out: NetworkOPs
318+
JSS(fee_ref); // out: NetworkOPs, DEPRECATED
319319
JSS(fetch_pack); // out: NetworkOPs
320320
JSS(first); // out: rpc/Version
321321
JSS(firstSequence); // out: NodeToShardStatus

src/test/app/TxQ_test.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -4843,13 +4843,13 @@ class TxQ1_test : public beast::unit_test::suite
48434843
drops[jss::base_fee] == "0");
48444844
BEAST_EXPECT(
48454845
drops.isMember(jss::median_fee) &&
4846-
drops[jss::base_fee] == "0");
4846+
drops[jss::median_fee] == "0");
48474847
BEAST_EXPECT(
48484848
drops.isMember(jss::minimum_fee) &&
4849-
drops[jss::base_fee] == "0");
4849+
drops[jss::minimum_fee] == "0");
48504850
BEAST_EXPECT(
48514851
drops.isMember(jss::open_ledger_fee) &&
4852-
drops[jss::base_fee] == "0");
4852+
drops[jss::open_ledger_fee] == "0");
48534853
}
48544854
}
48554855

0 commit comments

Comments
 (0)