Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/cache 0.4 requirement creating problems #22

Open
esokullu opened this issue May 23, 2019 · 10 comments
Open

react/cache 0.4 requirement creating problems #22

esokullu opened this issue May 23, 2019 · 10 comments

Comments

@esokullu
Copy link

With newer packages that require react/cache 0.5

@WyriHaximus
Copy link
Owner

It's on my todo list for a while now. I'll try and get an update out later this week

@esokullu
Copy link
Author

and now 1.0 🙈 because of the latest react/http reqs.

@WyriHaximus
Copy link
Owner

WyriHaximus commented Sep 13, 2019

Whoops seems this one fell through. If you're up to it you can PR it, recently did another for 1.0, see https://github.com/WyriHaximus/reactphp-cache-redis/blob/master/src/Redis.php for inspiration. Not sure when I would have time for it as I'm pretty busy lately. But I'll try to squeeze it in somewhere soon.

@WyriHaximus
Copy link
Owner

@esokullu just pushed 60587f2 which includes all the changes to work with the latest cache and filesystem components

@esokullu
Copy link
Author

Sorry, I just saw these!

I was trying to give it a try, but here's the error message I receive:

PHP Warning:  strlen() expects parameter 1 to be string, array given in [....]/vendor/react/filesystem/src/Stream/WritableStreamTrait.php on line 14
PHP Warning:  base64_encode() expects parameter 1 to be string, array given in [...]/vendor/react/filesystem/src/ChildProcess/Adapter.php on line 216

with a setup like:

$filesystem = ReactFilesystem::create($this->loop);
$cache = new Filesystem($filesystem, sys_get_temp_dir());

This may be a React/Filesystem issue as well. Meanwhile, I am switching to the EIO extension to see if that is what's causing the issue.

@esokullu
Copy link
Author

yes, works like a breeze with eio installed. So, must be a React\Filesystem issue.

@WyriHaximus
Copy link
Owner

Interesting, does react/filesystem work when you have the EIO extension installed or are you using EIO directly?

@esokullu
Copy link
Author

No I wasn't using EIO directly. But there are still some issues. I'm investigating, I'll let you know.

@esokullu
Copy link
Author

Aargh... I was wrong, I'm still getting this same issue:

PHP Warning:  strlen() expects parameter 1 to be string, array given in [...]/vendor/react/filesystem/src/Stream/WritableStreamTrait.php on line 14
PHP Notice:  Array to string conversion in [...]/vendor/react/filesystem/src/Eio/Adapter.php on line 410

(slightly edited to hide paths)

@WyriHaximus
Copy link
Owner

Aargh... I was wrong, I'm still getting this same issue:

PHP Warning:  strlen() expects parameter 1 to be string, array given in [...]/vendor/react/filesystem/src/Stream/WritableStreamTrait.php on line 14
PHP Notice:  Array to string conversion in [...]/vendor/react/filesystem/src/Eio/Adapter.php on line 410

Could you try composer require react/filesystem:"dev-master as v0.1.13"?

(slightly edited to hide paths)

Hah I do the same 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants