Providing User Agent for Http.Download method #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
great！ |
Author
|
Perfect. Still, are there any reasons to not add the german language to the active languages? |
Member
|
no, |
Author
|
Then I will create a pull request for the german language again. Thanks! |
Member
|
#750 is a good example. |
Author
Member
|
Author
|
Ahh perfect... sorry i am quite new to git stuff. |
bao-qian
pushed a commit
that referenced
this pull request
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some websites need a user-agent in the header to download a file from them, i added this to the Download Method.
For example, the download from discogs-api will fail when the user-agent is not provided.
Are there any reasons to not add the german language to the active languages?