Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior changed incompatibly between 0.18.3 and 0.18.6? #188

Open
time4tea opened this issue Aug 29, 2024 · 2 comments
Open

Behavior changed incompatibly between 0.18.3 and 0.18.6? #188

time4tea opened this issue Aug 29, 2024 · 2 comments

Comments

@time4tea
Copy link

Before going into this issue, I can confess I am very confused by the api, particularly around context propagation, having to cast to specific implementations to maybe get a root span and all the docs telling to use functions that are deprecated.

As an open source maintainer I know it is hard to keep docs up to date, but a simple realistic example test would be really helpful.

Previously I was doing this:

final span = tracer.startSpan("z");

This would give a span of parent:"" (empty) - a root.

But since 0.8.5 or 6, it returns a span with parent 00000000

I dont know how to convince it not to. I'm also unsure how to create an inner span.

final outer = tracer.startSpan("outer");
final inner = tracer.startSpan("inner")

doesn't work, but how to make it work?

I dont really want to use global things, especially as global tracer prover doesn't seem to allow itself to be reset (required for tests that might need to access it)

Sorry if this sounds like a complaint, it isn't! I'd really appreciate a real example.

The examples given seen to use a completed span as a parent (end is called before passing it down) so I don't quite get what that is doing.

Thank you!!

James

@dankhan-helmet
Copy link

dankhan-helmet commented Sep 3, 2024

Not quite sure, but this might be related to a problem I'm running into too

@time4tea
Copy link
Author

time4tea commented Sep 3, 2024

@dankhan-helmet I am using honeycomb, and that's how I noticed this issue.. no more root spans.

I reverted to 0.18.3 temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants