Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we handle i18n for FSE templates? #19

Open
iandunn opened this issue Aug 20, 2021 · 6 comments
Open

How should we handle i18n for FSE templates? #19

iandunn opened this issue Aug 20, 2021 · 6 comments
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Question Needs input from others before actionable

Comments

@iandunn
Copy link
Member

iandunn commented Aug 20, 2021

It sounds like blockbase had to create PHP templates

...and TwentyTwentyTwo had to create patterns.

those may be good arounds for us too, but still seems pretty hacky. it doesn't sound like gutenberg really supports i18n yet.

will that be an issue when we launch this? i guess we'd continue using the old theme on rosetta sites anyway, since those just use the main theme for the entire site, rather than having a separate WP site for the blog.

@iandunn iandunn added the [Type] Question Needs input from others before actionable label Aug 20, 2021
@iandunn iandunn added this to the Initial Launch milestone Aug 20, 2021
@coreymckrill
Copy link
Contributor

i guess we'd continue using the old theme on rosetta sites anyway, since those just use the main theme for the entire site, rather than having a separate WP site for the blog.

Ah this is good to know. In that case, I would guess that updating the design on rosetta sites would be a separate project. I would lean towards not worrying about translations for this project right now. There won't be a ton of strings, so it hopefully wouldn't be hard to add in translations once GB supports them.

@iandunn
Copy link
Member Author

iandunn commented Aug 20, 2021

That sounds good to me 👍🏻

@iandunn
Copy link
Member Author

iandunn commented Dec 29, 2021

Re-opening since we'll want to do this eventually, but moving it to the farthest-away milestone.

Maybe blocked by #13. We'll probably want to move this to the parent theme repo, and then backport to News.

@iandunn iandunn reopened this Dec 29, 2021
@MaggieCabrera
Copy link
Collaborator

MaggieCabrera commented Jan 24, 2022

We can use block patterns for this. Check how Blockbase does it for the 404 pages while hiding the block pattern from the users in the editor.

@iandunn
Copy link
Member Author

iandunn commented Jan 24, 2022

Yeah, that could be an acceptable workaround in the meantime, but I'm hoping one of the Gutenberg tickets above will provide something analogous to how PHP/JS files are translated. IMO that'd be a much better solution.

@MaggieCabrera
Copy link
Collaborator

Yeah, that could be an acceptable workaround in the meantime, but I'm hoping one of the Gutenberg tickets above will provide something analogous to how PHP/JS files are translated. IMO that'd be a much better solution.

From my experience and what I've talked with other GB contributors I don't think that's happening any time soon and it's not something easy to solve or clear as to how to do so

@ryelle ryelle added the [Status] Blocked (external) Blocked by something outside our direct control label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Blocked (external) Blocked by something outside our direct control [Type] Question Needs input from others before actionable
Projects
None yet
Development

No branches or pull requests

4 participants