Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance code quality related to WP_Theme_JSON::append_to_selector() calls by introducing prepend_to_selector() #4380

Conversation

felixarntz
Copy link
Member

@felixarntz felixarntz commented Apr 25, 2023

Backport of WordPress/gutenberg#50266

Trac ticket: https://core.trac.wordpress.org/ticket/58193


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@oandregal
Copy link
Member

Hi Felix, would you be able to send this PR to Gutenberg? That's where the source of truth for this code lives.

This makes sense from a "code wise" perspective to me. It'd be good to engage the original authors/reviewers for help as well, so the pattern is more widely shared.

@felixarntz
Copy link
Member Author

@oandregal Makes sense. I just opened WordPress/gutenberg#50266 :)

@felixarntz
Copy link
Member Author

Closing this in favor of WordPress/gutenberg#50266

@tellthemachines
Copy link
Contributor

Hi! I see the respective change in Gutenberg has been merged, but unless I'm mistaken this PR will still be needed to make the update in core? Shall we reopen it?

@felixarntz
Copy link
Member Author

Thanks @tellthemachines, good point. I thought this was gonna be backported together with #4412, but I've reopened this PR and updated it against trunk as well as the minor changes in order to match the Gutenberg implementation that was merged.

@felixarntz
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants