Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Audio block: Improve focus style #207

Closed
carolinan opened this issue Oct 1, 2020 · 1 comment · Fixed by #230
Closed

Audio block: Improve focus style #207

carolinan opened this issue Oct 1, 2020 · 1 comment · Fixed by #230

Comments

@carolinan
Copy link
Contributor

Describe the bug
When the audio block is added, it looks different in different browsers as expected, but the outer focus style in all browsers needs to be more visible.

In Firefox, there is no spacing between the element and the thin dotted outline so the outline is difficult to see.
In chrome, the focus is thicker, but there needs to be more spacing, see screenshot below.

To Reproduce
Steps to reproduce the behavior:

  1. Add an audio block. There is an audio file in the Theme Unit Test if needed
  2. View the front
  3. Place focus on the block
  4. See error

Screenshots
Chrome at the top, Firefox below
Focus styles for the audio block are not visible enough

@carolinan carolinan added [Component] Default blocks Issues related to adjusting default blocks Accessibility (a11y) labels Oct 1, 2020
@melchoyce
Copy link
Contributor

Solid focus style:

outline-offset: 5px;
outline: 2px solid var(--global--color-border);

Alternately, dotted like buttons:

outline-offset: 5px;
outline: 2px dotted var(--global--color-border);

(Unsure if border is the right variable here, just knew it would get the right color when testing)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants