Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute Post Content block with Excerpt block in template-query-loop.php #628

Closed
michalczaplinski opened this issue Oct 23, 2024 · 3 comments
Labels
[Type] Bug An existing feature does not function as intended.

Comments

@michalczaplinski
Copy link

Description

The template-query-loop.php pattern should use the Excerpt block instead of the Post Content block. Otherwise, the "Reload full page" toggle is enabled and the Query Loop cannot use enhanced pagination.

That's because the Post Content block is incompatible with the enhanced pagination of the Query Loop block. The Post Content block could contain any arbitrary content, and there is currently no reliable way to detect if it doesn't have content that might be incompatible. See WordPress/gutenberg#55539 for more context.

Step-by-step reproduction instructions

  1. Open the site editor for the Home template.
  2. Open the block inspector.
  3. Observe that the "Reload full page" toggle is enabled.

Expected behavior

The "Reload full page" toggle should be disabled thus allowing for enhanced pagination.

Screenshots

Image

@michalczaplinski michalczaplinski added the [Type] Bug An existing feature does not function as intended. label Oct 23, 2024
@beafialho
Copy link
Contributor

Is this the pattern used in the default "Blog Home" template? If that's the case, we want this template to show the entire blog post, not the excerpt. This is a fundamental characteristic of the theme.

@carolinan
Copy link
Contributor

I agree with @beafialho. It also helps show the post formats. If the excerpt was used, the posts with formats would always be identical to the other posts.

Users who needs to use this pagination can update the block in the template, or choose one of the other template designs.

@michalczaplinski
Copy link
Author

Gotcha, thank you for clarifying 🙂 . I think we can close the issue then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

No branches or pull requests

3 participants