Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag theme releases #195

Open
ockham opened this issue Feb 4, 2021 · 5 comments
Open

Tag theme releases #195

ockham opened this issue Feb 4, 2021 · 5 comments

Comments

@ockham
Copy link
Contributor

ockham commented Feb 4, 2021

Hey, would y'all be okay with tagging theme versions (i.e. using git tags)? E.g. assigning the tag [email protected] to f3d2c0d.

This would make it simpler and more transparent to refer to this GH repo as a source from other places.

The concrete motivation for this is WordPress/gutenberg#28692 (comment): It'd allow us to pin Gutenberg's (end-to-end test) dependency to

WordPress/theme-experiments/tt1-blocks#[email protected]

rather than

WordPress/theme-experiments/tt1-blocks#f3d2c0d
@carolinan
Copy link
Collaborator

I am not sure how to create (and tag) a release with only the theme - @aristath @kjellr do we create a new branch for only TT1 Blocks?

@ockham
Copy link
Contributor Author

ockham commented Feb 5, 2021

I am not sure how to create (and tag) a release with only the theme - @aristath @kjellr do we create a new branch for only TT1 Blocks?

I don't think there needs to be a separate branch, nor does the tag have to include one theme only! The tag would really just serve as a pointer that indicates the snapshot of the repo that reflects a given version of the theme -- it's perfectly fine to ignore what's going on with the other themes. (We do this in the Gutenberg repo -- if you look at the tags list there, there are e.g. tags for individual versions of each @wordpress/ package.)

@carolinan
Copy link
Collaborator

carolinan commented Feb 8, 2021

@kjellr
Copy link
Collaborator

kjellr commented Feb 8, 2021

I think what you did there works Carolina — since this is a monorepo, I think we can just ignore the other themes when we package. Thanks for tagging this release!

@ockham
Copy link
Contributor Author

ockham commented Feb 8, 2021

Thanks a lot @carolinan, this looks perfect 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants