TT1 Blocks: migrate table block styles #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
commented
Dec 9, 2020
scruffian
reviewed
Dec 10, 2020
|
With the outstanding Gutenberg issue and PR, this becomes a one line addition. I think it should be fine to land or we can put it in blocked until those Gutenberg changes are addressed. |
|
Since we won't need this change once WordPress/gutenberg#27651 lands then I think Blocked makes more sense. |
|
Besides the table caption size, and the text colors breaking in different ways depending on if TT1 blocks or Twenty Twenty-One is active, I do not see what needs to be changed here? left: TT1 Blocks. Right: Twenty Twenty-One |
|
Note: The above screenshot is without the PR applied. |
|
Yeah, I think we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CSS needed to match the table block styles from TT1, addressing part of #131.
It does not address the calendar block which is included in TT1's table block styles but I think should be addressed in another PR.
I would test the following use cases:
Note that this PR requires WordPress/gutenberg#27628 to look fully correct.