Update exception classes to use centralized error extraction and Request DTOs

Author: Mohamed Khaled

src/Providers/Http/Exception/RedirectException.php

@@ -4,6 +4,7 @@
 
 namespace WordPress\AiClient\Providers\Http\Exception;
 
+use WordPress\AiClient\Common\Exception\RuntimeException;
 use WordPress\AiClient\Providers\Http\DTO\Response;
 
 /**
@@ -15,7 +16,7 @@
  *
  * @since n.e.x.t
  */
-class RedirectException extends RequestException
+class RedirectException extends RuntimeException
 {
     /**
      * Creates a RedirectException from a redirect response.

src/Providers/Http/Exception/ResponseException.php

@@ -4,9 +4,9 @@
 
 namespace WordPress\AiClient\Providers\Http\Exception;
 
-use Psr\Http\Client\ClientExceptionInterface;
 use WordPress\AiClient\Common\Exception\RuntimeException;
 use WordPress\AiClient\Providers\Http\DTO\Response;
+use WordPress\AiClient\Providers\Http\Utilities\ErrorMessageExtractor;
 
 /**
  * Exception class for HTTP response errors.
@@ -17,7 +17,7 @@
  *
  * @since 0.1.0
  */
-class ResponseException extends RuntimeException implements ClientExceptionInterface
+class ResponseException extends RuntimeException
 {
     /**
      * Creates a ResponseException for missing expected data.
@@ -72,28 +72,10 @@ public static function fromBadResponse(Response $response): self
             $response->getStatusCode()
         );
 
-        // Handle common error formats in API responses.
-        $data = $response->getData();
-        if (
-            is_array($data) &&
-            isset($data['error']) &&
-            is_array($data['error']) &&
-            isset($data['error']['message']) &&
-            is_string($data['error']['message'])
-        ) {
-            $errorMessage .= ' ' . $data['error']['message'];
-        } elseif (
-            is_array($data) &&
-            isset($data['error']) &&
-            is_string($data['error'])
-        ) {
-            $errorMessage .= ' ' . $data['error'];
-        } elseif (
-            is_array($data) &&
-            isset($data['message']) &&
-            is_string($data['message'])
-        ) {
-            $errorMessage .= ' ' . $data['message'];
+        // Extract error message from response data using centralized utility
+        $extractedError = ErrorMessageExtractor::extractFromResponseData($response->getData());
+        if ($extractedError !== null) {
+            $errorMessage .= ' ' . $extractedError;
         }
 
         return new self($errorMessage, $response->getStatusCode());

src/Providers/Http/Exception/ServerException.php

@@ -4,7 +4,9 @@
 
 namespace WordPress\AiClient\Providers\Http\Exception;
 
+use WordPress\AiClient\Common\Exception\RuntimeException;
 use WordPress\AiClient\Providers\Http\DTO\Response;
+use WordPress\AiClient\Providers\Http\Utilities\ErrorMessageExtractor;
 
 /**
  * Exception thrown for 5xx HTTP server errors.
@@ -14,7 +16,7 @@
  *
  * @since n.e.x.t
  */
-class ServerException extends RequestException
+class ServerException extends RuntimeException
 {
     /**
      * Creates a ServerException from a server error response.
@@ -34,28 +36,10 @@ public static function fromServerError(Response $response): self
             $response->getStatusCode()
         );
 
-        // Handle common error formats in API responses
-        $data = $response->getData();
-        if (
-            is_array($data) &&
-            isset($data['error']) &&
-            is_array($data['error']) &&
-            isset($data['error']['message']) &&
-            is_string($data['error']['message'])
-        ) {
-            $errorMessage .= ' - ' . $data['error']['message'];
-        } elseif (
-            is_array($data) &&
-            isset($data['error']) &&
-            is_string($data['error'])
-        ) {
-            $errorMessage .= ' - ' . $data['error'];
-        } elseif (
-            is_array($data) &&
-            isset($data['message']) &&
-            is_string($data['message'])
-        ) {
-            $errorMessage .= ' - ' . $data['message'];
+        // Extract error message from response data using centralized utility
+        $extractedError = ErrorMessageExtractor::extractFromResponseData($response->getData());
+        if ($extractedError !== null) {
+            $errorMessage .= ' - ' . $extractedError;
         }
 
         return new self($errorMessage, $response->getStatusCode());