Rename fromClientError to fromClientErrorResponse and fix test expectations

Author: Mohamed Khaled

src/Providers/Http/Exception/ClientException.php

@@ -109,7 +109,7 @@ public static function fromBadRequestToUri(string $uri, string $errorDetail = 'I
      * @param Response $response The HTTP response that failed.
      * @return self
      */
-    public static function fromClientError(Response $response): self
+    public static function fromClientErrorResponse(Response $response): self
     {
         $errorMessage = sprintf(
             'Client error (%d): Request was rejected due to client-side issue',

src/Providers/Http/Util/ResponseUtil.php

@@ -50,7 +50,7 @@ public static function throwIfNotSuccessful(Response $response): void
 
         // 4xx Client Errors
         if ($statusCode >= 400 && $statusCode < 500) {
-            throw ClientException::fromClientError($response);
+            throw ClientException::fromClientErrorResponse($response);
         }
 
         // 5xx Server Errors

tests/unit/Providers/OpenAiCompatibleImplementation/AbstractOpenAiCompatibleImageGenerationModelTest.php

@@ -221,7 +221,7 @@ public function testGenerateImageResultApiFailure(): void
         $model = $this->createModel();
 
         $this->expectException(ClientException::class);
-        $this->expectExceptionMessage('Bad request (400): {"error": "Bad Request"}');
+        $this->expectExceptionMessage('Client error (400): Request was rejected due to client-side issue - Bad Request');
 
         $model->generateImageResult($prompt);
     }

tests/unit/Providers/OpenAiCompatibleImplementation/AbstractOpenAiCompatibleModelMetadataDirectoryTest.php

@@ -109,7 +109,7 @@ function (string $modelId) {
         );
 
         $this->expectException(ClientException::class);
-        $this->expectExceptionMessage('Bad request (400): {"error": "Bad Request"}');
+        $this->expectExceptionMessage('Client error (400): Request was rejected due to client-side issue - Bad Request');
 
         $directory->listModelMetadata();
     }

tests/unit/Providers/OpenAiCompatibleImplementation/AbstractOpenAiCompatibleTextGenerationModelTest.php

@@ -161,7 +161,7 @@ public function testGenerateTextResultApiFailure(): void
         $model = $this->createModel();
 
         $this->expectException(ClientException::class);
-        $this->expectExceptionMessage('Bad request (400): {"error": "Bad Request"}');
+        $this->expectExceptionMessage('Client error (400): Request was rejected due to client-side issue - Bad Request');
 
         $model->generateTextResult($prompt);
     }